Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix loading spinner responsiveness when default font size is modified #8295

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix: fix loading spinner responsiveness when default font size is modified #8295

merged 1 commit into from
Jun 6, 2023

Conversation

amtins
Copy link
Contributor

@amtins amtins commented May 29, 2023

Description

This PR fixes the responsiveness of the loading spinner when the default font size of .video-js is modified.

loading-spinner.webm

Specific Changes proposed

  • Use em instead of px to make the component responsive

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #8295 (fc2d839) into main (f1558c6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8295   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files         112      112           
  Lines        7483     7483           
  Branches     1804     1804           
=======================================
  Hits         6163     6163           
  Misses       1320     1320

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@misteroneill misteroneill added the needs: LGTM Needs one or more additional approvals label Jun 2, 2023
@misteroneill misteroneill changed the title Fix loading spinner responsiveness fix: fix loading spinner responsiveness when default font size is modified Jun 6, 2023
@misteroneill misteroneill added confirmed and removed needs: LGTM Needs one or more additional approvals labels Jun 6, 2023
@misteroneill misteroneill merged commit f075177 into videojs:main Jun 6, 2023
@amtins amtins deleted the fix/loading-spinner-responsiveness branch November 5, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wseymour15 wseymour15 wseymour15 approved these changes

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amtins @misteroneill @wseymour15